$ the-wire · showcase
HTTP/2 client pool folds into Transport; modernize fixes its own bad rewrites
By RepoJournal · Filed · About Go · Composed from the cited sources · methodology
net/http deletes its separate HTTP/2 client connection pool in favor of the Transport pool, while the modernize analyzer gets three fixes for rewrites that produced code that did not compile.
net/http: remove the HTTP/2 client connection pool golang/go
All HTTP/2 client connection management now lives in the net/http Transport pool, closing a long list of open bugs that clustered around two pools disagreeing about idle connections. Code that reaches through http2.Transport for pooling behavior should go through http.Transport.
go/analysis/passes/modernize: unsafefuncs: check the offset operand golang/tools
The unsafefuncs fix that rewrites unsafe.Pointer(uintptr(ptr) + y) to unsafe.Add(ptr, y) dropped a uintptr conversion, which broke compilation when y was a constant too large for int, such as ^uintptr(0), or was uintptr(x) for a non-int x.
go/analysis/passes/modernize: minmax: avoid unused := variable golang/tools
The minmax rewrite now checks that a variable declared with := has at least one use outside the if statement before collapsing it, since removing the if could produce a "declared and not used" error. The unsafefuncs pass skips a fix rather than emit one that will not compile: "No fix is offered now for a constant larger than math.MaxInt32," since int is 32 bits on some platforms.
uuid: speed up decoding and encoding golang/go
UUID.UnmarshalText made as many as five calls to hex.Decode and AppendText five to hex.Encode, neither of which inlines; both drop to at most one call, exploiting the optimizations recent encoding/hex work introduced.
simd/archsimd: restore Permute* methods as deprecated wrappers golang/go
Permute, ConcatPermute, PermuteOrZero and PermuteOrZeroGrouped return as //go:fix inline wrappers in deprecated_amd64.go, undoing an earlier rename to the *LookupMod* names that broke existing archsimd callers. The long tail: GOEXPERIMENT=vetfiles gates the proposed go.vet support in go test with no effect unless enabled, gopls drops its prompts to upvote microsoft/vscode#208093 now that VS Cod...