The Wire · Showcase
CRITICAL OIDC INJECTION IN DOCS PREVIEW WORKFLOW PATCHED
By RepoJournal · Filed · About PyTorch
PyTorch's docs-preview CI trusted fork-controlled artifacts in a context with token-write permissions, exposing the entire build pipeline to code injection.
The `upload-docs-preview.yml` workflow ran with `id-token: write` and directly sourced an artifact produced by a fork-triggerable job, meaning untrusted PR code could inject shell commands and forge OIDC tokens [1]. Fix landed. Separately, the compiler team unified unbacked symbol handling in FX to stop crashing on re-exports of already-lowered programs [2], while Inductor unblocked scaled-GEMM subprocess precompile by fixing two RecursionErrors in quantization constraints [3]. On the infra side, test-infra added per-trunk-commit workflow-duration KPI tracking to HUD [6], then reverted and re-applied numpy preview-build support for Python 3.15 wheels [7]. TorchTitan shipped window FIFO scheduling for RL training to prevent head-of-line blocking in rollout buffers [4], and lifted PTRR load balancer restrictions so flex-attention models with multiple named masks can now run [5]. Activity this period: 56 commits, 9 PRs, 1 release across pytorch, torchtitan, and test-infra.
One email a day. Unsubscribe in one click.
Keep up with PyTorch in about 3 minutes a day: what actually shipped — the commits, pull requests, releases, and security advisories that matter.
One email a day. Unsubscribe in one click. Read a past issue →
Action items
- → Review docs-preview workflow changes; verify no fork-triggered workflows source untrusted artifacts pytorch/pytorch [immediate]
- → Update to latest FX unbacked-symbol handling if you re-export lowered programs pytorch/pytorch [plan]
- → Monitor TorchTitan RL tests; window FIFO changes scheduler behavior pytorch/torchtitan [monitor]
References
- [1] [docs-preview] Stop sourcing untrusted artifact metadata (OIDC/shell injection) (#191017) pytorch/pytorch
- [2] [fx] _rename_unbacked_to: unify instead of assert on unbacked dest (#190083) (#190083) pytorch/pytorch
- [3] [inductor][NVGEMM] Enable scaled-GEMM subprocess precompile (#189841) pytorch/pytorch
- [4] [rl] add window FIFO scheduling ↗ pytorch/torchtitan
- [5] [cp] Allow PTRR load balancer to select a mask from a dict (#3972) pytorch/torchtitan
- [6] Add "pull workflow duration per trunk commit" KPI to HUD ↗ pytorch/test-infra
- [7] Build numpy for preview Python (3.15/3.15t) and host on download.pytorch.org ↗ pytorch/test-infra