$ the-wire · showcase
Loong64 MOVW/MOVV immediate fix, Windows ad-hoc package errors
By RepoJournal · Filed · About Go · Composed from the cited sources · methodology
2 people shipped this
Two compiler-toolchain fixes land: loong64's MOV{W,V}P address arithmetic drops a sign-extension step, and go/packages stops matching only Linux error strings when an ad-hoc package file is missing.
cmd/internal/obj/loong64: fix wrong immediate field loading for MOV{W,V}P instructions golang/go
The loong64 assembler loaded the bit[31-16] portion of the si14 immediate via AADDV16 without carrying the sign bit of the low 16 bits, so the computed address for MOVW and MOVV memory operands was wrong. It now sign-extends that lower half as well, matching the documented shift-left-2-then-sign-extend sequence before the value is added to Rbase.
go/packages: fix Windows response to ad-hoc package file missing golang/tools
The go/packages driver only recognized the Linux error text for a missing ad-hoc package file, so on Windows the failure surfaced as an unrecognized error rather than the intended response. The change adds a guess at the Windows error strings; Peter Weinberger's description is candid that it is a "guess at the Windows error strings", so expect follow-up if the wording differs by Windows version.
