The Wire · Showcase
DYNAMO FIXES GRAPH-BREAKING SDPA PARAMS, PAT SVD LEAK BREAKS DOWNSTREAM TESTS
By RepoJournal · Filed · About PyTorch
PyTorch shipped fixes for two critical compilation and module patching bugs overnight that were silently breaking downstream workflows.
Dynamo can now construct SDPAParams inside compiled regions without graph-breaking under fullgraph=True [1], routing the pybind11 class through TorchInGraphFunctionVariable following the torch.nn.Parameter pattern. The same Dynamo reland [3] restores getattr_static for internal attribute probing after it was reverted for inflating frame counts, but the fix is back in and the frame-count assertions pass. On the CUDA front, _scaled_mm with float8 output was silently dropping the scale_result parameter [5], causing identical bitwise outputs for different scales. Over in pytorch/ao, insert_svd_modules_ was mutating the shared nn.Linear class directly, leaving AttributeError traps in weight access across unrelated modules [6], breaking torch.compile tests in int4/int8/float8 workflows after any pat SVD test ran. The fix patches a private per-instance subclass instead. Meanwhile, c10d's TorchComms integration no longer requires users to mutate c10d internals before calling init_process_group [2], and out-of-range float conversions in tensor creation tests are now restricted to valid ranges [4].
One email a day. Unsubscribe in one click.
Keep up with PyTorch in about 3 minutes a day: what actually shipped — the commits, pull requests, releases, and security advisories that matter.
One email a day. Unsubscribe in one click. Read a past issue →
Action items
- → If running torch.compile with int4/int8/float8 quantization, upgrade pytorch/ao immediately pytorch/ao [immediate]
- → Rebuild with latest Dynamo if you rely on SDPAParams in compiled graphs pytorch/pytorch [plan]
- → Verify float8 _scaled_mm scaling behavior in your production models pytorch/pytorch [monitor]
References
- [1] [Dynamo] Support SDPAParams construction in fullgraph (#190839) pytorch/pytorch
- [2] [c10d][torchcomms] Add MCCL backend wrapper example (#190292) (#191034) pytorch/pytorch
- [3] [Dynamo] Reland: Use getattr_static when probing internal attributes (#190970) pytorch/pytorch
- [4] [caffe2] Avoid out-of-range float->integral conversions (UB) in test_tensor_creation_ops (#191025) (#191025) pytorch/pytorch
- [5] [CUDA] Restore scale_result for float8 _scaled_mm output (#190979) pytorch/pytorch
- [6] [pat] Fix SVD class leakage into `nn.Linear` from #4587 (#4613) pytorch/ao