$ the-wire · showcase
gopls deletes MoveType, Go telemetry hardens paths and dates
By RepoJournal · Filed · About Go · Composed from the cited sources · methodology
10 people shipped this
gopls drops a code action and fixes a refactor that emitted uncompilable code, while the Go telemetry server gets two rounds of input-validation hardening and net/http's HTTP/3 test scaffolding consolidates onto synctest.
gopls/internal/golang: delete MoveType golang/tools
The "move type" code action and its settings are gone, so editor clients invoking that refactor lose it entirely. Anyone who scripted or keybound MoveType needs to switch to another path before their next gopls upgrade.
gopls/internal/analysis/unusedvariable: remove assignments to unused variables golang/tools
The unusedvariable analyzer used to strip only the declaration, leaving assignments to an undeclared variable behind; it now calls refactor.DeleteVar on every remaining left-hand-side use, with DeleteVar extended to handle '=' assignments and redeclarations in ':=' statements.
godev/internal/storage: reject unusual FS object names golang/telemetry
NewFSObject now runs its name through filepath.Localize, which rejects io/fs paths containing .. components and names not representable on the local filesystem, such as a leading NUL on Windows. The companion change validates the /charts/... endpoint against actual dates instead of looking up arbitrary values.
net/http: drop afterTest golang/go
afterTest, the goroutine-stack scan that caught leaked goroutines after tests, is removed; synctest now fails a test when a bubble exits with goroutines still running. setParallel, which conditionally skipped parallelism when afterTest might run, is replaced with plain t.Parallel.
internal/facts: remove brute-force importMap traversal golang/tools
Unitchecker now decodes facts through its own importer's package map rather than enumerating every object reachable from direct imports, and the old NewDecoder is deleted with NewDecoderFunc renamed to NewDecoder. The commit benchmarks go vet with a printf-only unitchecker on kubernetes/cmd/kube-apiserver.
all: go fmt std golang/go
Everything else was quiet: go fmt across the standard library, the tiff lzw reader receiving the same hi-code overflow fix already applied to compress/lzw, //go:noinline on the SIMD intrinsic helpers to cut compile time, HTTP/3 test enabling and deflaking in net/http, imported-by counts wired into pkgsite search, missing GCS objects now returning 404 instead of 500, a regenerated telemetry uplo...
Action items
- → Migrate off gopls' "move type" code action before your next gopls upgrade golang/tools [plan]
