$ the-wire · showcase
Docs search fragments fixed, Benevity link restored
By RepoJournal · Filed · About Django
Two long-standing djangoproject.com bugs are fixed: docs search scroll-to-text fragments now land on the right line, and the footer's Benevity link points to the donate page.
Docs search results on djangoproject.com used to build scroll-to-text fragments from PostgreSQL search headlines. Since Pygments splits code into tokens, the extracted text introduced spacing not present in the rendered page, so the browser found no match and dropped readers at the top. The fix handles four cases, including full HTML unescaping of the headline [1]. The related PR describes the same issue and shows a reproduction against production, where `?q=execute` currently emits a fragment with a stray space after `%s` [2].
The footer's Benevity link pointed to an anchor on the fundraising page that was removed in 2015, leaving readers at the top with no sign of the content. The link now goes to the donate page via `{% url 'homepage' %}`, matching the corrected list item on the fundraising page [3].
Ownership for fundraising and CoC pages moved to the respective working groups. CODEOWNERS now routes changes to the fundraising pages to the fundraising WG [4] and CoC templates to the CoC WG [5]. Dashboard benchmarks added results for ubuntu-latest [6].
Action items
- → Verify the docs search fragment fix in your local build if you depend on the search feature django/djangoproject.com [monitor]
- → Review any references to the old Benevity footer link django/djangoproject.com [plan]
References
- [1] Fixed #1954 -- Corrected spacing in docs search scroll-to-text fragments. ↗ django/djangoproject.com
- [2] Fixed #1954 -- Corrected scroll-to-text fragments in docs search results ↗ django/djangoproject.com
- [3] Fixed #2654 -- Pointed the footer's Benevity link at the donate page. (#2827) ↗ django/djangoproject.com
- [4] Added fundraising WG as code owners of fundraising pages. ↗ django/djangoproject.com
- [5] Added the CoC WG as code owners of CoC templates. ↗ django/djangoproject.com
- [6] Results for ubuntu-latest added [skip ci] ↗ django/django-asv